Cards with links shouldn't go to edit mode when link is clicked

Fixed or Completed
1

Per https://discord.com/channels/857305113936134204/876918592313110608/926999398372745256

When you ⌘/Ctrl-click a link on a card, the card itself goes into edit mode. This feels janky. It probably shouldn’t do this:)

1 Like
2

The reason this happens and can’t easily be prevented is because the card opens on mousedown (for a variety of reasons, one of which is responsiveness). The link starts opening on mouseup. So by the time the app knows that you want to open a link, the card is already opened.

1 Like
3

Can the link button be excluded/filtered so it doesn’t trigger the whole card opening?

1 Like
4

i got it working, also b/c so many ppl have asked for it over time, i’ll also add a user preference for opening links on a card in a new tab

2 Likes
5

you can try this out for yourself at https://deploy-preview-212--kinopio-client.netlify.app/

Screen Shot 2022-01-01 at 11.23.44 PM
Screen Shot 2022-01-01 at 11.23.44 PM570×630 67.7 KB

1 Like
6

I’m still seeing the card go into edit mode when I click the link button right now (on the staging site)…

7

this link button?

Screen Shot 2022-01-01 at 11.28.54 PM

1 Like
8

Yep, when I ⌘-click, it opens the edit dialog. Or if I have the new option toggled, when I click on that button, it opens the edit dialog.

9

:rofl: you kept your word

1 Like
10

a new fix released, try it in 5 :slight_smile:

1 Like