Firefox silently fails to save to localStorage

I was using brave on macOS to avoid Firefox, other students where using Chrome on windows and same issue some cards just didn’t save. popped a few screen shots of consoles into discord adding here for safe keeping

if you compare screenshot 1 with the last one you can see some of the cards that then went missing.
Could it have something to do with quickly moving between spaces this is when I first noticed it in Firefox I was linking spaces together and moving between them

1 Like

these are both from my mac but I didnt write the comment about Dory… so how did it sync and then go ?

the leg shaking comment the same - most of the missing cards where not created by me . I think mine are missing on both screen shots

1 Like

@adamprocter, @jordanne,
just to double-check are you able to reproduce this consistently/all-the-time, or do you encounter the issue sporadically/unpredictably?

some more possible fixes added, and added a bunch more logging around pruning the cache. Let me know what the logs say if/when you see this again thx!

1 Like

Just got it today.
Logs here
I don’t know if this is related - but I have three monitors now, so I opened up three Kinopio spaces at the same time, one for each screen, hahaha. And that’s when it happened.

2 Likes

hm i’m guessing it’s too late to expand the keys in these messages? (i’ll try to work w this though)

especially the value in :

can you check your firefox version? it looks like a v similar sounding localstorage error was fixed in v85

1 Like

pushed out another potential fix and more logging, still not able to repro this myself :frowning:

1 Like

also added an error notification that should appear whenever a localstorage saving error occurs

Screen Shot 2021-11-15 at 11.25.11 AM

2 Likes

this was seen by @Charles in discord

storeLocal https://kinopio.club/assets/index.803050d6.js:1
    updateUser https://kinopio.club/assets/index.803050d6.js:1
    updateFavoriteSpaceIsEdited https://kinopio.club/assets/index.803050d6.js:1
    Bc https://kinopio.club/assets/vendor.b5b84eb1.js:6
    commit https://kinopio.club/assets/vendor.b5b84eb1.js:6
    commit https://kinopio.club/assets/vendor.b5b84eb1.js:6
    _withCommit https://kinopio.club/assets/vendor.b5b84eb1.js:6
    commit https://kinopio.club/assets/vendor.b5b84eb1.js:6
    commit https://kinopio.club/assets/vendor.b5b84eb1.js:6
    commit https://kinopio.club/assets/vendor.b5b84eb1.js:6
    restoreSpaceComplete https://kinopio.club/assets/index.803050d6.js:1
    Bc https://kinopio.club/assets/vendor.b5b84eb1.js:6
    dispatch https://kinopio.club/assets/vendor.b5b84eb1.js:6
    dispatch https://kinopio.club/assets/vendor.b5b84eb1.js:6
    dispatch https://kinopio.club/assets/vendor.b5b84eb1.js:6
    restoreSpaceInChunks https://kinopio.club/assets/index.803050d6.js:1
    Rc https://kinopio.club/assets/vendor.b5b84eb1.js:1

from the msgs:
he saw the error but The error seems to persist until I close the other tabs and reload twice. cards after the error do not persist (as expected).

perhaps I should also use stronger wording in the error dialog so that ppl know that cards added after seeing it won’t save correctly.

any extra info and context you could add here @charles would be appreciated!

1 Like

Hmm yeah so I think this has happened for me 4 or 5 times and each time I’ve had multiple browser tabs open. (This is something that I do maybe 50% of the time, so it’s unclear whether that itself is the problem.) I’ve noticed that cards that happen after this message shows up are not saved, however I’m pretty sure that cards that were created before this message shows up are.

I’m using firefox version 95.0.2 (64-bit) on an m1 macbook pro. If there’s anything else I can do, I’d be happy to test things out or provide more info!

2 Likes

I’m full time investigating this , using ff 96. When you update your FF, can you let me know if you still see this? (haven’t been able to repro this yet)

1 Like

I’ve been using Firefox 97 for a few minutes and I’ve seen that warning about “Local storage error has occured, please refresh”. I don’t see any data loss yet though, nor are there errors in the console, just a warning (I’ll screencap it next time).

btw, I think occured is a typo: should be occurred :slight_smile:

1 Like

I tend to see that error toast when I navigate to another space within the app.

Here’s the warning in the console:

Oh, and the space I navigated to is not read-only or open.

Strangely, I haven’t seen this error since I last posted about it. I’m on Firefox 96 now - maybe it’s a 95 bug?

1 Like

I came to my work computer this morning where I had a Firefox window open with Kinopio. The “Local storage error has occured” message was there. I hit refresh, and it was still there. At this point, I also saw the scarier error in the console about quota being exceeded.

I opened the space in another browser and I’m still seeing sync happening though. Even if I refresh the page, the error toast persists.

1 Like

i’ll be shipping a possible fix to this specific issue alongside box-select. In the meantime, you’ll have to sign out and back in to fix this

1 Like

the mitigation for this issue is now live

1 Like

What is the mitigation? Although I hadn’t seen any data loss recently, I still want to keep an eye on it.

Fixes a bug when purging cached spaces that would keep ff showing sync errors even after refresh

1 Like